Save tabs number in Url to persist tab when go to other paths #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntbm
reviewed
Nov 15, 2021
AriaMoradi
requested changes
Nov 16, 2021
There was a problem hiding this comment.
Two things are broken:
1- URLs like http://127.0.0.1:3000/library?unread=1 don't work
2- When a filter is active, changing tabs clears all filters
Maybe handling tab number in query prams is a better solution?
…n tabs number was presents in the url
AriaMoradi
approved these changes
Nov 17, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an Optional parameter to the library path to provide which tab to go to. It also replaces the Tab Number in the url when tab is changed.